Skip to content

fix(@schematics/angular): enable tsc downlevelIteration #14698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2019
Merged

fix(@schematics/angular): enable tsc downlevelIteration #14698

merged 1 commit into from
Jun 7, 2019

Conversation

alan-agius4
Copy link
Collaborator

We by default now use ES2015. Users can use ES2015 iterations however the ES5 build will fail.

Fixes #14697

@alan-agius4 alan-agius4 requested a review from clydin June 6, 2019 22:05
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jun 6, 2019
We by default now use ES2015. Users can use ES2015 iterations however the ES5 build will fail.

Fixes #14697
@alan-agius4 alan-agius4 closed this Jun 7, 2019
@alan-agius4 alan-agius4 reopened this Jun 7, 2019
@kyliau
Copy link
Contributor

kyliau commented Jun 7, 2019

@alan-agius4 This PR doesn't merge cleanly on the patch branch. Could you please submit another PR for patch?

@kyliau kyliau added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jun 7, 2019
@kyliau kyliau merged commit c6fb34a into angular:master Jun 7, 2019
@alan-agius4 alan-agius4 deleted the fix-down-level branch June 8, 2019 15:27
@alan-agius4
Copy link
Collaborator Author

@kyliau here's the patch version #14713

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng build throws downlevelIteration error targeting es2015
4 participants